Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adagio Bid Adapter: update to current standards #10038

Open
patmmccann opened this issue Jun 2, 2023 · 0 comments · May be fixed by #11351
Open

Adagio Bid Adapter: update to current standards #10038

patmmccann opened this issue Jun 2, 2023 · 0 comments · May be fixed by #11351
Assignees
@osazos
Labels
9.0 API Change

Comments

@patmmccann
Copy link
Collaborator

patmmccann commented Jun 2, 2023 •
edited

Type of issue

In Prebid 5 and #5804 Criteo locked to a version and made inclusion on their build side include optional. Adagio has some parallel issues to address. This issue is to track that work.

https://github.com/onfocusio/Prebid.js/blob/815b3bf075a24c894ce11f3355f3504afc8145c3/modules/adagioBidAdapter.js#L188C1-L189C1 also accesses LS directly

Related #9296 and #9296 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@osazos osazos

Labels
9.0 API Change
Projects
Prebid.js Tactical Issues table
Status: PR submitted
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adagio Bid Adapter: external script compliance onfocusio/Prebid.js
2 participants
@patmmccann @osazos