Publir Bid Adapter : initial release #10851
Conversation
ChrisHuie
changed the title
|
@osazos @ChrisHuie |
There was a problem hiding this comment.
Hi @mdghousesaqlain,
- I got a CORS error on your endpoint, can you check it?
- please add more tests to increase coverage rate
- regarding your documentation:
- you should mention "video" in addition of "banner" as supported media_types
- add
coppa_supported: true, your code seems to support it
modules/publirBidAdapter.js
Outdated
| * @returns {object} the common params object | ||
| */ | ||
| function generatePubGeneralsParams(generalObject, bidderRequest) { | ||
| const domain = window.location.hostname; |
There was a problem hiding this comment.
you should rely on bidderRequest.refererInfo object
There was a problem hiding this comment.
Please don't resolve conversation by yourself.
The modification you did is not correct, refererInfo is an object which provide a lot of information. Take a look a this.
There was a problem hiding this comment.
Okay, I'm taking all the info but using only bidderRequest.refererInfo.domain on the endpoint, as i need only domain info
modules/publirBidAdapter.js
Outdated
| return; | ||
| } | ||
| logInfo('onBidWon:', bid); | ||
| fetch('//wsfd8lvwt6.execute-api.us-east-1.amazonaws.com/default/publirPrebidImpressionTracker', { method: 'POST', mode: 'no-cors', body: JSON.stringify(bid), credentials: 'include', headers: { 'Content-Type': 'application/json' } }); |
There was a problem hiding this comment.
Please use ajax() from import {ajax} from '../src/ajax.js';
There was a problem hiding this comment.
Please review, code modified as suggested.
|
@ChrisHuie @osazos @patmmccann |
|
Hi @mdghousesaqlain sounds good. But there is sill the point about your coverage rate, it is expected to be > 80%.
Can you improve it? After that, it should be ok. |
|
@osazos |
Type of change
Description of change
How to test
Use Google Chrome
Go to https://www.cravehub.com/test_prebid.html, we are loading Publir Bid Adapter.
Other information
-> Docs PR