Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pstudio Bid Adapter: initial release #10980

Merged
merged 7 commits into from Mar 12, 2024
Merged

Conversation

cckowalewska
Copy link
Contributor

Type of change

Description of change

This is initial PR with PStudio bid adapter
Currently module supports banner as well as instream video mediaTypes.

Test parameters

Those parameters should be used to get test responses from the adapter.

var adUnits = [
  // Banner ad unit
  {
    code: 'test-div-1',
    mediaTypes: {
      banner: {
        sizes: [[300, 250]],
      },
    },
    bids: [
      {
        bidder: 'pstudio',
        params: {
          // id of test publisher
          pubid: '22430f9d-9610-432c-aabe-6134256f11af',
          floorPrice: 1.25,
        },
      },
    ],
  },
  // Instream video ad unit
  {
    code: 'test-div-2',
    mediaTypes: {
      video: {
        context: 'instream',
        playerSize: [640, 480],
        mimes: ['video/mp4'],
        protocols: [3],
      },
    },
    bids: [
      {
        bidder: 'pstudio',
        params: {
          // id of test publisher
          pubid: '22430f9d-9610-432c-aabe-6134256f11af',
          floorPrice: 1.25,
        },
      },
    ],
  },
];

Other information

@cckowalewska
Copy link
Contributor Author

@ChrisHuie @osazos friendly reminder about this PR :)

@osazos
Copy link
Collaborator

osazos commented Feb 19, 2024

Hi @cckowalewska, review will be done today.

Copy link
Collaborator

@osazos osazos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Two required changes please:

You must support price floors module: the Adapters that accept a floor parameter must also support the floors module -- look for a call to the getFloor() function.

You can't set cookies directly, you must use the StorageManager

modules/pstudioBidAdapter.js Outdated Show resolved Hide resolved
@cckowalewska
Copy link
Contributor Author

@osazos All issues fixed :)

  • I have added floors module
  • I am using Storage module
  • isEmpty is exported from utils module

@cckowalewska
Copy link
Contributor Author

@osazos friendly reminder about this PR :)

Co-authored-by: Olivier <osazos@adagio.io>
@osazos osazos self-requested a review March 12, 2024 12:42
Copy link
Collaborator

@osazos osazos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@osazos osazos merged commit 101ec94 into prebid:master Mar 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants