You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
An enormous variety of code constructs device portion of bid requests by accessing navigator, typically in slightly varying ways, or worse, copy pasted between one adapter to the next.
Core should be able to gather all the required information in navigator and construct the device object on the request. Banning access to navigator should make the project smaller, the code more maintainable, bid requests more uniform, and finally, if something is missing from core and someone needs to add it, that additional information will propagate to more integrations more quickly.
The text was updated successfully, but these errors were encountered:
cc @giuseppe-exads you just added a bunch of logic relying on navigator for the exads adapter. We'd prefer you rely on the request object and if you need any of the transformations you committed, you consider issuing a pull request to the request object formation
Type of issue
Proposal
Description
An enormous variety of code constructs device portion of bid requests by accessing navigator, typically in slightly varying ways, or worse, copy pasted between one adapter to the next.
Prebid.js/modules/snigelBidAdapter.js
Line 120 in 17f3468
Core should be able to gather all the required information in navigator and construct the device object on the request. Banning access to navigator should make the project smaller, the code more maintainable, bid requests more uniform, and finally, if something is missing from core and someone needs to add it, that additional information will propagate to more integrations more quickly.
The text was updated successfully, but these errors were encountered: