Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kargo Bid Adapter: floors and CreativeID update #11153

Merged
merged 39 commits into from Mar 14, 2024
Merged

Conversation

sj1815
Copy link
Contributor

@sj1815 sj1815 commented Feb 28, 2024

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Following PR has a feature and bugfix update for review

  • Feature:
    Update code to use correct creativeID value being sent in Bid Response to the Publisher.
  • Bugfix:
    Updates code to correctly use bid adapter implementation of floors module

Other information

jsadwith and others added 26 commits April 14, 2023 17:34
* wrap in if statement

* update test for schain, file formatting
Co-authored-by: Julian Gan  <juliangan07@gmail.com>
KRKPD-619 Adding site to Kargo adapter.
* update bid Response to use actual creativeID

* update spec

* fix nomencalature based on Kargo's service
@Fawke
Copy link
Contributor

Fawke commented Mar 4, 2024

Hi @sj1815, can you please pull in master, I see some tests fail in Circle ci. Hopefully pulling in the changes from master fixes it.

@sj1815
Copy link
Contributor Author

sj1815 commented Mar 7, 2024

Hey @Fawke thanks for reaching out. I pushed a fix, should be good now.

@sj1815 sj1815 changed the title Update Prebid Adapter to use correct creative ID value. Kargo Bid Adapter: floors and CreativeID update Mar 8, 2024
@Fawke Fawke merged commit 77254c2 into prebid:master Mar 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants