Kargo Bid Adapter: floors and CreativeID update #11153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wrap in if statement * update test for schain, file formatting
Co-authored-by: Julian Gan <juliangan07@gmail.com>
KRKPD-619 Adding site to Kargo adapter.
* update bid Response to use actual creativeID * update spec * fix nomencalature based on Kargo's service
|
Hi @sj1815, can you please pull in master, I see some tests fail in Circle ci. Hopefully pulling in the changes from master fixes it. |
fix/krkpd-928 | Revert nomenclature change to fix tests
|
Hey @Fawke thanks for reaching out. I pushed a fix, should be good now. |
2 tasks
KRKPD-987: floors should reference Floors Module
sj1815
changed the title
Fawke
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Following PR has a feature and bugfix update for review
Update code to use correct creativeID value being sent in Bid Response to the Publisher.
Updates code to correctly use bid adapter implementation of floors module
Other information