Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lockr AIM user module: initial release #11159

Merged
merged 12 commits into from May 1, 2024

Conversation

KEPlockr
Copy link
Contributor

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

The following PR adds the lockr AIM module as a part of prebid.

Alternative Identity Manager (AIM) is a unified container for identity and data management.

With AIM’s self-service platform, publishers seamlessly integrate and activate alternative IDs like LiveRamp’s Authenticated Traffic Solution (ATS), Unified ID 2.0 (UID2), ID5 and more. The burden of due diligence and maintenance, coupled with the benefits of server-side calls result in the adoption of multiple alternative IDs, clean rooms like InfoSum and CDPs like Blueconic based on their specific needs.

modules/lockrAIMIdSystem_shared.js Outdated Show resolved Hide resolved
@patmmccann
Copy link
Collaborator

You may notice you're not passing lint checks as well

@patmmccann patmmccann self-assigned this Mar 14, 2024
@KEPlockr
Copy link
Contributor Author

You may notice you're not passing lint checks as well

This was caused by us following the documentation and calling "configparams", we have updated this to "config" and it addressed the issue. It was within the lockrAIMIdSystem.js

@KEPlockr
Copy link
Contributor Author

@jdwieland8282 - can you expand on the "needs docs" label, as all such documentation is included in the "lockrAIMIdSystem.md" file. Thank you.

@jdwieland8282
Copy link
Member

You need a docs PR against the prebid.github.io repo. This will get your documentation on to prebid.org's website

@patmmccann
Copy link
Collaborator

@KEPlockr you're not passing the linter because you arent following our code style rules

image

* @returns {lockrAIMId}
*/
getId(config, consentData) {
if (consentData?.gdprApplies === true) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want to pass your endpoint the gpp string?

Copy link
Contributor

@chris-lockr chris-lockr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are all these modules changing? Shouldn't we only be touching lockrAIMdSystem?

@patmmccann patmmccann changed the title lockr AIM user module lockr AIM user module: initial release Apr 16, 2024
@patmmccann
Copy link
Collaborator

Lgtm

You still need to pr https://github.com/prebid/prebid.github.io/pulls?q=is%3Apr+is%3Aopen+lockr it seems?

@patmmccann patmmccann merged commit 0e58601 into prebid:master May 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants