Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preciso Bid Adapter : update on valid request checks #11161

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

NikhilGopalChennissery
Copy link
Contributor

@NikhilGopalChennissery NikhilGopalChennissery commented Mar 1, 2024

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

@ChrisHuie
Copy link
Collaborator

seems similar to #11106

@NikhilGopalChennissery
Copy link
Contributor Author

NikhilGopalChennissery commented Mar 8, 2024

seems similar to #11106

Hi @ChrisHuie , this new PR (#11161 ) has the latest changes that we have made. Could you please review this PR instead of #11106? We would like to close the old PR (#11106).

@ChrisHuie ChrisHuie changed the title Preciso BidAdapter : update Preciso Bid Adapter : update on valid requeat checks Mar 11, 2024
@NikhilGopalChennissery
Copy link
Contributor Author

Hi @ChrisHuie , we would like to know if there are any issues with the PR for merging.

Thank you

@ChrisHuie
Copy link
Collaborator

@jlquaccia can you take a look at this when you get a chance

@NikhilGopalChennissery
Copy link
Contributor Author

NikhilGopalChennissery commented Apr 22, 2024

Hey @ChrisHuie, is there are any concerns with the PR for merging.

Thank you

@ChrisHuie
Copy link
Collaborator

ChrisHuie commented Apr 22, 2024

Hey @ChrisHuie, is there are any concerns with the PR for merging.

Thank you

I can help finish up this review. Jason might be busy with Fledge and other crazy ad world stuff. One question I do have is around the access of sharedId also? Don't believe I have seen that in an adapter before but think liveintent might do something similar. @NikhilGopalChennissery

@NikhilGopalChennissery
Copy link
Contributor Author

NikhilGopalChennissery commented Apr 28, 2024

Hi @ChrisHuie, We are using this sharedId for the purpose of usersync. Will it cause any impact if we use sharedId in bid Adapter? We don't have any idea about access the sharedId from bid Adapter. So could you please guide us for further steps.

Thank you

@NikhilGopalChennissery NikhilGopalChennissery changed the title Preciso Bid Adapter : update on valid requeat checks Preciso Bid Adapter : update on valid request checks Apr 28, 2024
@ChrisHuie ChrisHuie requested review from Fawke and removed request for jlquaccia May 2, 2024 14:41
@ChrisHuie ChrisHuie assigned Fawke and unassigned jlquaccia May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants