New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preciso Bid Adapter : update on valid request checks #11161
base: master
Are you sure you want to change the base?
Conversation
seems similar to #11106 |
Hi @ChrisHuie , this new PR (#11161 ) has the latest changes that we have made. Could you please review this PR instead of #11106? We would like to close the old PR (#11106). |
Hi @ChrisHuie , we would like to know if there are any issues with the PR for merging. Thank you |
@jlquaccia can you take a look at this when you get a chance |
Hey @ChrisHuie, is there are any concerns with the PR for merging. Thank you |
I can help finish up this review. Jason might be busy with Fledge and other crazy ad world stuff. One question I do have is around the access of sharedId also? Don't believe I have seen that in an adapter before but think liveintent might do something similar. @NikhilGopalChennissery |
Hi @ChrisHuie, We are using this sharedId for the purpose of usersync. Will it cause any impact if we use sharedId in bid Adapter? We don't have any idea about access the sharedId from bid Adapter. So could you please guide us for further steps. Thank you |
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information