Taboola Bid Adapter : add for support fledge #11192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHuie
changed the title
dgirardi
reviewed
Mar 11, 2024
modules/taboolaBidAdapter.js
Outdated
| serverResponse.body.ext.igbid.forEach((igbid) => { | ||
| let buyerdata; | ||
| try { | ||
| buyerdata = JSON.parse(igbid.igbuyer[0]?.buyerdata) |
There was a problem hiding this comment.
you can use safeJSONParse to reduce the boilerplate.
I am not sure about the purpose of doing it here as well as in the loop below: if the first buyer has invalid buyerdata the whole igbid is discarded. But if the second one does, only the buyer is discarded. Is that intended?
There was a problem hiding this comment.
Hi @dgirardi,
thanks for the suggestion. Changed the parse to safeParse.
Regarding the second part of comment - you got correct the intention. I want to discard only the buyer in case of failure inside of the loop and not the full action config.
There was a problem hiding this comment.
Hi @dgirardi,
Are there any other issues or PR can be merged?
dgirardi
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
[ x] Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Support fledge in taboola bid adapter
Other information