Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taboola Bid Adapter : add for support fledge #11192

Merged
merged 4 commits into from Mar 19, 2024

Conversation

aleskanderl
Copy link
Contributor

Type of change

  • Bugfix

  • [ x] Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Support fledge in taboola bid adapter

Other information

@ChrisHuie ChrisHuie changed the title Taboola Bid Adapter - support fledge Taboola Bid Adapter : add for support fledge Mar 11, 2024
@ChrisHuie ChrisHuie requested a review from dgirardi March 11, 2024 14:25
serverResponse.body.ext.igbid.forEach((igbid) => {
let buyerdata;
try {
buyerdata = JSON.parse(igbid.igbuyer[0]?.buyerdata)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use safeJSONParse to reduce the boilerplate.

I am not sure about the purpose of doing it here as well as in the loop below: if the first buyer has invalid buyerdata the whole igbid is discarded. But if the second one does, only the buyer is discarded. Is that intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dgirardi,
thanks for the suggestion. Changed the parse to safeParse.
Regarding the second part of comment - you got correct the intention. I want to discard only the buyer in case of failure inside of the loop and not the full action config.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dgirardi,
Are there any other issues or PR can be merged?

@patmmccann patmmccann merged commit 4b4648e into prebid:master Mar 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants