Yandex: add id system #11196
Yandex: add id system #11196
Conversation
chernodub
force-pushed
the
yandex-id-system
branch
from
409db5f
to
b95702e
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return id; | ||
| } | ||
|
|
||
| _setUid(userId) { |
Check failure
Code scanning / CodeQL
Insecure randomness High
|
Hi @ChrisHuie! Our team would really appreciate it if you (or anybody from the Prebid Team) could look into this PR. If anything needs to be updated/explained — I'm here. Thanks! |
|
@chernodub looks like there is a CodeQL issue around insecure randomness and linting issues with single quotes. Also, there are no unit tests to accompany this pr. Don't see any docs either here for this new ID -> https://github.com/prebid/prebid.github.io . Can you please update? |
chernodub
force-pushed
the
yandex-id-system
branch
from
b95702e
to
a57d1f0
Compare
|
Hi @ChrisHuie! Thanks for the opportunity to improve the code. I've added the changes you recommended 🙏
Please let me know if anything else needs to be added/improved. Thanks! |
There was a problem hiding this comment.
the docs PR prebid/prebid.github.io#5268 suggests there's a bidders parameter ... not seeing this in the code?
modules/yandexIdSystem.js
Outdated
| }, | ||
| eids: { | ||
| [YANDEX_ID_KEY]: { | ||
| source: BIDDER_CODE, |
There was a problem hiding this comment.
eids are generally a domain, e.g. yandex.com
There was a problem hiding this comment.
Hi @bretg, thanks!
- I changed the eid key to domain name. Is it a convention? I wonder what's the reason. We at Yandex have different region-specific domains (e.g.
.com,.kz, etc) so I'm not sure if it's a good idea hardcoding the TLD here. - Considering
bidders. As far as I understood, this is not a userland parameter, but an option provided by Prebid SDK to control which bidders will receive the eid — here is the link to the docs. Are you sure we need to handle that manually in the module code? I tested this end-to-end I see it working fine without any adjustments on module's side. I also see the related references ofconfig.biddersin the core code. I'd be happy if you could point out what I'm missing here, thanks!
There was a problem hiding this comment.
the eids source key is what DSPs look for when they code for a given ID. It's possible that you only care about your own bidder so the value of the eids source isn't as important, but yes, the convention is that it's a domain.
we're good on the bidders part. thanks.
chernodub
force-pushed
the
yandex-id-system
branch
from
848d32d
to
8d91459
Compare
|
Hi @ChrisHuie! All the updates are done. I'd really appreciate it if you could look into this once more. Thank you! |
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
New ID system
PR to the docs repo: prebid/prebid.github.io#5268
Description of change
Added yandex id system that gets the id provided by Yandex Metrica tag that is optionally installed by the publishers. In case the id is not set by the tag, it will be set from the yandexIdSystem sumbodule.