New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anyclip Bid Adapter : initial release #11200
Conversation
For your external PubTag code. I think the only other bidder doing something like this is Criteo and they seem to have gotten worked out where you do not need to ask the user to include an extra script in the head. I think you should attempt to do it that way, having the user have to add an extra script isn't an intended way of doing it. You should be able to see it here Feel free to push back, I'm not absolutely certain about this. |
@Rothalack, yes, you right, it is similar to the Criteo adapter, but Criteo uses https://github.com/criteo-forks/Prebid.js/blob/master/modules/criteoBidAdapter.js#L186 This is normal for us: all of our publishers must include our PubTag library in order to use our prebid adapter. |
Hi @basil79 ; criteo is in process of removing this dependency in prebid 9 |
Hi @patmmccann , give me their pr I will check |
@Rothalack, any updates? |
There is a divide in opinion on whether or not the way you're doing this should be allowed. I've voiced my thoughts on this. I do not feel like I'm in the position to make this decision, it's a policy decision. I'm unsure if @patmmccann s comment here was a request for you to make a change or just information for you. |
@Rothalack , criteo has been using this method for many years, we want to use it too. I haven't found any policies or restrictions to not do it this way. |
They're doing it the intended way, which is to have the external JS in an open source github repo under Prebid. My understanding at least is that this is to keep the spirit of open source and have the code be publicly accountable. |
but we don't load external JS file using Prebid, our publishers do that |
Right, which is where the divide in opinion occurs. |
bottom line, any publisher wishing to use any prebid adapter must contact the company (ex SSP provider) that owns the adapter to obtain connection params etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to go ahead and approve and merge this. I don't see any more discussion on this topic and it seems like Pat was in approval.
* prepare anyclipBidAdapter * added spec test for anyclipBidAdapter * cleanup * fixed readme * added getFloor support --------- Co-authored-by: Basil Goldman <>
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Added new bid adapter AnyClip. It uses the external PubTag library for fast bids, first please add the following file to the
<HEAD>
Be sure to test the integration with your adserver using the Hello World sample page. -->
Other information