Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smartyads Bid Adapter : add user id fields #11221

Merged

Conversation

rishko00
Copy link
Contributor

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

@ChrisHuie ChrisHuie changed the title Smartyads Bid Adapter/add user id fields Smartyads Bid Adapter : add user id fields Mar 20, 2024
@Rothalack
Copy link
Collaborator

Looks good, working in testing.

A side note, you have accountId marked as optional on your docs page, but in my testing it appears to be required. You may want to consider updating your docs for that. That doesn't hold you up here or anything.

@Rothalack Rothalack merged commit 673f44f into prebid:master Mar 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants