Smartadserver Bid Adapter: Update default value of startDelay video parameter #11225
+50
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support floors per media type
Rework payloads enriching
Add GPP support
Add gpid support
Support additional video params
Update default startDelay
patmmccann
requested changes
Mar 18, 2024
| } | ||
| } | ||
| return 2;// Default value for all exotic cases set to bid.params.video.startDelay midroll hence 2. | ||
| return 1; // SADR-5619 |
There was a problem hiding this comment.
this appears wrong; what do you do if videoMediaType.startdelay is say, 180? In this case, you appear to ignore the declaration and guess that it is preroll?
Also, you seem to have dropped the .startdelay from your switch?
There was a problem hiding this comment.
Good point, @patmmccann, I've updated the implementation. Thx.
There was a problem hiding this comment.
If the publisher specifies midroll starting at 3 minutes (180), you are calling it preroll still?
There was a problem hiding this comment.
You are completely right. It's fixed.
There was a problem hiding this comment.
Hi @patmmccann, could you review it, please? Thx.
Include videoMediaType's startdelay
patmmccann
approved these changes
Apr 3, 2024
mefjush
pushed a commit
to adhese/Prebid.js
that referenced
this pull request
Apr 8, 2024
…arameter (prebid#11225) * Smartadserver Bid Adapter: Add support for SDA user and site * Smartadserver Bid Adapter: Fix SDA support getConfig and add to unit testing * support floors per media type * Add GPP support * Rework payloads enriching * Add gpid support * Support additional video params * vpmt as array of numbers * Fix comment * Update default startDelay * Include videoMediaType's startdelay * Handle specified midroll --------- Co-authored-by: Meven Courouble <mcourouble@smartadserver.com> Co-authored-by: Krzysztof Sokół <88041828+smart-adserver@users.noreply.github.com> Co-authored-by: Dariusz O <darekodz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
[x] Feature
Description of change
The startDelay parameter is set to 1 by default.