Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewability at time of auction calculations in adapters & Recycled getBoundingClientRect() use #11232

Open
patmmccann opened this issue Mar 18, 2024 · 0 comments
Open

Viewability at time of auction calculations in adapters & Recycled getBoundingClientRect() use #11232

patmmccann opened this issue Mar 18, 2024 · 0 comments

Comments

@patmmccann
Copy link
Collaborator

Type of issue

Copy pasted code blocks

Prebid.js/modules/marsmediaBidAdapter.js

Line 400 in 40dd3b6

let { width, height, left, top, right, bottom } = element.getBoundingClientRect();

Prebid.js/modules/brightcomSSPBidAdapter.js

Line 245 in 40dd3b6

let {width, height, left, top, right, bottom} = element.getBoundingClientRect();

Prebid.js/modules/brightcomBidAdapter.js

Line 219 in 40dd3b6

let {width, height, left, top, right, bottom} = element.getBoundingClientRect();

Prebid.js/modules/underdogmediaBidAdapter.js

Line 316 in 40dd3b6

} = element.getBoundingClientRect();

Prebid.js/modules/33acrossBidAdapter.js

Line 575 in 40dd3b6

let { width, height, left, top, right, bottom } = element.getBoundingClientRect();

Prebid.js/modules/onomagicBidAdapter.js

Line 192 in 40dd3b6

let { width, height, left, top, right, bottom } = element.getBoundingClientRect();

all appear to use this logic and should import the library

Prebid.js/libraries/percentInView/percentInView.js

Line 3 in 40dd3b6

let {width, height, left, top, right, bottom} = element.getBoundingClientRect();

Also, given:
https://gist.github.com/paulirish/5d52fb081b3570c81e3a

are we comfortable with this behavior?
@patmmccann patmmccann changed the title Recycled getBoundingClientRect() use Viewability at time of auction calculations in adapters & Recycled getBoundingClientRect() use Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Prebid.js Tactical Issues table
Status: Needs Req
Milestone
No milestone
Development

No branches or pull requests
1 participant
@patmmccann