Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elem.innerText performance issue #11233

Open
patmmccann opened this issue Mar 18, 2024 · 0 comments
Open

elem.innerText performance issue #11233

patmmccann opened this issue Mar 18, 2024 · 0 comments
Assignees
@ChrisHuie
Labels
9.0 API Change good first issue

Comments

@patmmccann
Copy link
Collaborator

patmmccann commented Mar 18, 2024 •
edited

Type of issue

Enhancement

Description

https://gist.github.com/paulirish/5d52fb081b3570c81e3a suggests element.innerText causes layout recalculations

Luckily only a few times is it used

Prebid.js/modules/idImportLibrary.js

Line 158 in 40dd3b6

email = targetElement.innerText;

Prebid.js/modules/adhashBidAdapter.js

Line 123 in 40dd3b6

const content = window.top.document.body.innerText.toLowerCase();

Prebid.js/modules/freewheel-sspBidAdapter.js

Line 79 in 40dd3b6

price: priceNode.textContent || priceNode.innerText

Prebid.js/modules/freewheel-sspBidAdapter.js

Line 113 in 40dd3b6

domain.push(domainNode.textContent || domainNode.innerText);

I wonder if we can somehow eliminate its use and ban calling it from the library via the linter?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChrisHuie ChrisHuie

Labels
9.0 API Change good first issue
Projects
Prebid.js Tactical Issues table
Status: Blocked
Milestone
No milestone
Development

No branches or pull requests
2 participants
@patmmccann @ChrisHuie