OMS Adapter: add gpid support #11238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askuksov
force-pushed
the
oms/adapter-update
branch
from
ef5327a
to
92ea750
Compare
patmmccann
reviewed
Mar 21, 2024
modules/omsBidAdapter.js
Outdated
|
|
||
| const imp = { | ||
| id: bid.bidId, | ||
| banner: { | ||
| format: processedSizes, | ||
| ext: { | ||
| viewability: viewabilityAmountRounded | ||
| viewability: viewabilityAmountRounded, | ||
| ...gpidData |
There was a problem hiding this comment.
why put this on imp.banner.ext when it belongs where you pulled it from, on imp.ext?
There was a problem hiding this comment.
@patmmccann good catch, thank you, fixed
|
@ChrisHuie unit tests for GPID have been added. |
ChrisHuie
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Adding support for GPID based on the GPT Pre-Auction Module