Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OMS Adapter: add gpid support #11238

Merged
merged 3 commits into from Mar 25, 2024
Merged

Conversation

prBigBrother
Copy link
Contributor

Type of change

  • Feature

Description of change

Adding support for GPID based on the GPT Pre-Auction Module


const imp = {
id: bid.bidId,
banner: {
format: processedSizes,
ext: {
viewability: viewabilityAmountRounded
viewability: viewabilityAmountRounded,
...gpidData
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why put this on imp.banner.ext when it belongs where you pulled it from, on imp.ext?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patmmccann good catch, thank you, fixed

@prBigBrother
Copy link
Contributor Author

@ChrisHuie unit tests for GPID have been added.

@ChrisHuie ChrisHuie merged commit c5e8af7 into prebid:master Mar 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants