Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debugging module: add PAAPI support #11240

Merged
merged 8 commits into from Mar 22, 2024
Merged

Debugging module: add PAAPI support #11240

merged 8 commits into from Mar 22, 2024

Conversation

dgirardi
Copy link
Collaborator

Type of change

  • Feature

Description of change

This updates the debugging module to support PAAPI:

  • intercept rules can be set to return no bids with then: null
  • PAAPI configs can now be mocked with paapi

For example:

pbjs.setConfig({
    debugging: {
        enabled: true,
        intercept: [
            {
                when: {},
                then: null,
                paapi: [
                    {
                        'seller': 'https://pa.openx.net',
                        'interestGroupBuyers': [
                            'https://demo2-bidder.deepintent.com'
                        ],
                        'decisionLogicUrl': 'https://pa.openx.net/s/537291777.js',
                        'trustedScoringSignalsUrl': 'https://pa.openx.net/tss',
                        'auctionSignals': {},
                        'sellerSignals': {},
                        'sellerCurrency': 'USD',
                        'perBuyerSignals': {
                            'https://demo2-bidder.deepintent.com': {
                                'buyerdatakey': 'buyerdatavalue'
                            }
                        }
                    }
                ]
            }
        ]
    }
});

vraybaud and others added 7 commits March 20, 2024 09:50
@vraybaud @dgirardi
Criteo Bid Adapter: use igi.igs to register fledge auction configs (p…
5839acc 
…rebid#11218)

Co-authored-by: v.raybaud <v.raybaud@criteo.com>
@pashaGhub @eldzis @dgirardi
setupad Bid Adapter: initial commit (prebid#11008)
d7a9efb 
* create setupadBidAdapter

* add setupadBidAdapter

* update setupadBidAdapter

* update metrics collection

* update analytics collection

* update getUserSyncs

* add setupadAnalyticsAdapter.js

* test setupadAnalyticsAdapter

* remove test: 1

* add GVLID && bug fixes && test updates

* remove setupadAnalyticsAdapter

* add userID module handling

* add GVLID && bug fixes && test updates

* remove setupadAnalyticsAdapter

* add userID module handling

* clean up && seat bugfix

* clean up logs

* add userID module handling

* update md && clean up

* Send setupad only on bidRequested

* Fix bidResponse and bidWon responses

* Improve bidResponse and bidWon logic

* Revert changes to specific files

* Remove test parameter

* Fix multiple bidResponse and bidTimeout calls to getPixelUrl

* eslint errors fixes(brackets added)

* Add extra checks for events

* Fix BIDDER_CODE const

* update reporting endpoint

* update setupadBidAdapter_spec.js REPORT_ENDPOINT

* update readme

* Revert "Merge branch 'prebid:master' into setupad-adapter"

This reverts commit 1c14dbe, reversing
changes made to 7fe9ea5.

* Revert "Revert "Merge branch 'prebid:master' into setupad-adapter""

This reverts commit a34e3e4.

* # This is a combination of 20 commits.
# This is the 1st commit message:

add setupadBidAdapter

# This is the commit message #2:

update setupadBidAdapter

# This is the commit message #3:

update metrics collection

# This is the commit message #4:

update analytics collection

# This is the commit message #5:

update getUserSyncs

# This is the commit message #6:

add setupadAnalyticsAdapter.js

# This is the commit message #7:

test setupadAnalyticsAdapter

# This is the commit message #8:

remove test: 1

# This is the commit message #9:

add GVLID && bug fixes && test updates

# This is the commit message #10:

remove setupadAnalyticsAdapter

# This is the commit message #11:

add userID module handling

# This is the commit message prebid#12:

clean up && seat bugfix

# This is the commit message prebid#13:

add userID module handling

# This is the commit message prebid#14:

add GVLID && bug fixes && test updates

# This is the commit message prebid#15:

remove setupadAnalyticsAdapter

# This is the commit message prebid#16:

add userID module handling

# This is the commit message prebid#17:

clean up logs

# This is the commit message prebid#18:

update md && clean up

# This is the commit message prebid#19:

Send setupad only on bidRequested

# This is the commit message prebid#20:

Fix bidResponse and bidWon responses

* # This is a combination of 22 commits.tree 8abae7e6dffc9a21ad11770713ba485fc610028a
parent cecfce3
author pavel <pavel@setupad.com> 1706627437 +0200
committer pavel <pavel@setupad.com> 1706627437 +0200
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQIzBAABCAAdFiEEqGYI3KX/FkbObQG8FABtd4pCs/AFAmW5EW0ACgkQFABtd4pC
 s/CK3w//WWJSFUlycnnNKTV2XfdcBjooOeZZvjpXVthwr09CCC4uO//kw4bPluhn
 f5fcVFdXzrY1AZ6ch8Wo3msX/Pkso014jIGd5aIWcHpNYFtffACwH/40Y8AcJNZd
 bsOZxVK0awPTz/RihC5eY+0J3cP+iFWP/FlYJoHEQIBXq/Eg6mWoAhxwpL/JvxbY
 QbLFWsRn2ckQ6ftOZgm3/jh8VLaG1zWbWImlWEs5Zel+CorJBTniTj58VbApelYD
 TFMgbSR2I4NGVaqNIrHePnSMsDATxalQ2nZPwY6raKCHWIbvoUPIn/OpDMMbKgC7
 nCwounNmObxFVoj3xusAZppzHpKPasY8xKWb2Kr7zfhZArsOMC6B7fYqQNK0cWG3
 8RR/10oheJD9M2kRlfLiqnRv7ExY08SQ/ZMo9LA8BeRUGBXhh6++8FKhKIHvX1gL
 k1R5W6c+NNWP+PDFsmrFpMn+LpYdl84I7yfYK5dHuw80od7f1wuAVYpswi6Cziy9
 /KY6/rfENvUrGTmWSh5GdDBel89ACCfFkasIKB92xhzKTfjzF/DXkc8XQZOMbt1j
 CsILgWMNfLPMo4Dlgdx/tYCSLLBNEtZ1/hhUcFQ3+0TzLf0GtMkvMnlBnDinqe1n
 1P30fQ2I5W5NJKDPrCOnRymI6QOAPFXtMF11R81mbB9H8asft/E=
 =oJtZ
 -----END PGP SIGNATURE-----

bugfixes

# This is the commit message prebid#22:

Remove test parameter

* # This is a combination of 26 commits.
parent cecfce3
author pavel <pavel@setupad.com> 1706627437 +0200
committer pavel <pavel@setupad.com> 1706627437 +0200
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQIzBAABCAAdFiEEqGYI3KX/FkbObQG8FABtd4pCs/AFAmW5EW0ACgkQFABtd4pC
 s/CK3w//WWJSFUlycnnNKTV2XfdcBjooOeZZvjpXVthwr09CCC4uO//kw4bPluhn
 f5fcVFdXzrY1AZ6ch8Wo3msX/Pkso014jIGd5aIWcHpNYFtffACwH/40Y8AcJNZd
 bsOZxVK0awPTz/RihC5eY+0J3cP+iFWP/FlYJoHEQIBXq/Eg6mWoAhxwpL/JvxbY
 QbLFWsRn2ckQ6ftOZgm3/jh8VLaG1zWbWImlWEs5Zel+CorJBTniTj58VbApelYD
 TFMgbSR2I4NGVaqNIrHePnSMsDATxalQ2nZPwY6raKCHWIbvoUPIn/OpDMMbKgC7
 nCwounNmObxFVoj3xusAZppzHpKPasY8xKWb2Kr7zfhZArsOMC6B7fYqQNK0cWG3
 8RR/10oheJD9M2kRlfLiqnRv7ExY08SQ/ZMo9LA8BeRUGBXhh6++8FKhKIHvX1gL
 k1R5W6c+NNWP+PDFsmrFpMn+LpYdl84I7yfYK5dHuw80od7f1wuAVYpswi6Cziy9
 /KY6/rfENvUrGTmWSh5GdDBel89ACCfFkasIKB92xhzKTfjzF/DXkc8XQZOMbt1j
 CsILgWMNfLPMo4Dlgdx/tYCSLLBNEtZ1/hhUcFQ3+0TzLf0GtMkvMnlBnDinqe1n
 1P30fQ2I5W5NJKDPrCOnRymI6QOAPFXtMF11R81mbB9H8asft/E=
 =oJtZ
 -----END PGP SIGNATURE-----

bugfixes

# This is the commit message prebid#22:

Remove test parameter

# This is the commit message prebid#23:

Fix multiple bidResponse and bidTimeout calls to getPixelUrl

# This is the commit message prebid#25:

eslint errors fixes(brackets added)

# This is the commit message prebid#26:

Add extra checks for events

* parent 75178b9
author pavel <pavel@setupad.com> 1706627694 +0200
committer pavel <pavel@setupad.com> 1706627694 +0200
gpgsig -----BEGIN PGP SIGNATURE-----

 iQIzBAABCAAdFiEEqGYI3KX/FkbObQG8FABtd4pCs/AFAmW5Em4ACgkQFABtd4pC
 s/BBUQ/+NXyHoxPM185YJLG9M1ySC/5vTT9W5mfwQ93cVDLCeuGnpsnmi4S21NuQ
 b7gSeokFjwztvVOUmh/xqMp4lTsvL53TUd00b1k4KGVSqgcF00Foit5g8fOGLYsI
 DAoqphYV6MWjpAun+II+ELY8QUkHR1cjTc7PEGtmf+8RnptGVdyJ6C9Ab8u9TQTY
 Apj5Srhfo3Tl8S+WScOxwwB/uqEJR4fhIrJyzFzdLDEb2olSPyrQUs87vQXlhEnK
 buPEg2F5JsRH6sw11Xp3TFNSZGxNnBSlTh9dixou5md4yRCv5a2TMef667N0BVDp
 lGgc7mCrRKXyqzphmmeHudiscEGFjtUPObXoHutSVw22wdARFCTpNFKBLLFn4v8o
 Zv1OvFdNprvHsoeW0HVlZdU7OKnDTRrko6DHk2AahxojjvAFEWuDsGYZNjhdQwRR
 lK1zm+SFQnKI0Eojd+f84fvKod9geGs640jyH/x5R4eYm4yjZb8SkRtd3cca88wS
 OuGq9LIkbU428b46l7VnDwudldTXPUU8eKfUtFRjdGtIWH9I3tK6TsRoCfTcXkv0
 smxYiiU1XHjAkkPFWQWEeFdfZ071snFKVWouU0AoKiq+PdRoS8+3AJqIQUjlA2sH
 AybnSkv9KxY/Rs1bnvMubsQm1GF66qVrbxBU6FILBv1JZYwj4yA=
 =Gbog
 -----END PGP SIGNATURE-----

bugfixes

update setupadBidAdapter_spec.js REPORT_ENDPOINT

update readme

Revert "Merge branch 'prebid:master' into setupad-adapter"

This reverts commit 1c14dbe, reversing
changes made to 7fe9ea5.

Revert "Revert "Merge branch 'prebid:master' into setupad-adapter""

This reverts commit a34e3e4.

* change double quote to single quote

---------

Co-authored-by: pavel <pavel@setupad.com>
Co-authored-by: Elgars Grodnis <elgars@setupad.com>

* bugfix setupadBidAdapter

remove getAdEl, spelling correction

* add onBidWon event

onBidWon event handling moved from custom to native onBidWon method

* minor bugfixes && remove funk getSiteObj && getDeviceObj

---------

Co-authored-by: pavel <pavel@setupad.com>
Co-authored-by: Elgars Grodnis <elgars@setupad.com>
@aymeric45 @dgirardi
New Bidder Adapter: Adlive Plus (prebid#11176)
e2f96ab 
* New Bidder adpater : Adlive Plus

* remove adlive plus md file (alias)
@lhxx121 @dgirardi
Discovery Bid Adapter : support topics (prebid#11209)
6d34941 
* Discovery Bid Adapter : add title, desc, keywords, hLen, nbw, hc, dm  add unit test resolve conflict

* Discovery Bid Adapter : add title, desc, keywords, hLen, nbw, hc, dm  add unit test

* Discovery Bid Adapter : synchronize mguid from third party cookie to first party cookie

* test

* Discovery Bid Adapter : Extend the expiration time of pmguid

* Discovery Bid Adapter : Extend the expiration time of pmguid

* Discovery Bid Adapter : Extend the expiration time of pmguid

* Discovery Bid Adapter : Extend the expiration time of pmguid

* Discovery Bid Adapter : support topics

* Discovery Bid Adapter : support topics

* Discovery Bid Adapter : support topics

* Discovery Bid Adapter : support topics

---------

Co-authored-by: lvhuixin <lvhuixin@baidu.com>
@github-matthieu-wipliez @dgirardi
Autoplay detection library: initial release && Teads Bid Adapter: det…
0cdc6ec 
…ect autoplay (prebid#11222)

* Add autoplay library

* Filter out bids with needAutoplay if autoplay is disabled

* Refactoring + add test

* Simplify logic for filtering bids

* Start detection in autoplay.js directly
@awiackiewicz @dgirardi
Adquery Bid Adapter: bidWon bugfix (prebid#11227)
5c139d0 
* removed ad data from bidWon event handler

* removed ad data from bidWon event handler

---------

Co-authored-by: Adam Wiąckiewicz <a.wiackiewicz@openmobi.pl>
@dgirardi
Merge branch 'master' into debugging-paapi
47967bc
ncolletti
ncolletti approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@ncolletti ncolletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@ncolletti ncolletti added the LGTM label Mar 22, 2024
@ncolletti ncolletti merged commit 9088112 into prebid:master Mar 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncolletti ncolletti ncolletti approved these changes

@robertrmartinez robertrmartinez Awaiting requested review from robertrmartinez

Assignees

@robertrmartinez robertrmartinez

@ncolletti ncolletti

Labels
feature LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@dgirardi @ncolletti @ChrisHuie @robertrmartinez @vraybaud @pashaGhub @aymeric45 @lhxx121 @github-matthieu-wipliez @awiackiewicz