Eight Pod Bid / Analytics Adapter : initial release #11260
Conversation
ChrisHuie
changed the title
|
I'm confused a bit, I get CI errors that does not relate to my updates Could you please help me with them? |
|
@GreDiSe rerunning tests. Hopefully that solves the issue |
|
@GreDiSe I tried rerunning the tests and still am getting these adapter errors. Can you try pulling in the current version of master and see if that fixes the tests issue? |
GreDiSe
force-pushed
the
eightPod
branch
2 times, most recently
from
aaa8ca9
to
e7bfe81
Compare
|
@spotxslagle i fixed build, now it works. Could you please review the PR? |
|
@ChrisHuie I appreciate your help, the build works now. Could you please review the PR? |
| } | ||
| } = CONSTANTS; | ||
|
|
||
| describe('', function() { |
There was a problem hiding this comment.
Please identify this as the adapter, it will make these tests much easier to identify if there are failures.
|
@GreDiSe @spotxslagle e2e tests hopefully will work on this go around but no worries if just the e2e tests are failing here. |
|
Thanks a lot for review and your approval |
|
Could you please tell me when are you planning to merge the PR? I saw that doc Pr cant be merged until release. |
|
@ChrisHuie Do mind me asking. I'd like to know when you are planing to do a release and this changes appears there? |
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information
Documentation PR: prebid/prebid.github.io#5230