Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Piridsystem: New ID System for WPM #11267

Merged
merged 54 commits into from Apr 15, 2024
Merged

Piridsystem: New ID System for WPM #11267

merged 54 commits into from Apr 15, 2024

Conversation

decemberWP
Copy link
Contributor

Type of change

  • Feature

Description of change

This PR introduces new User ID System for WPM

Module Name: pirIDSystem
Module Type: UserID Module
Maintainer: pawel.grudzien@grupawp.pl

Integration example:

pbjs.setConfig({
    userSync: {
        userIds: [{
            name: 'pirId',
            storage: {
                type: 'cookie',
                name: 'pirIdToken',
                expires: 7,
                refreshInSeconds: 360
            },
        }]
    }
});

wojciech-bialy-wpm and others added 30 commits August 18, 2020 11:16
@wojciech-bialy-wpm
Merge pull request #1 from prebid/master
1a37b62 
Update master branch of grupawp/Prebid.js
@wojciech-bialy-wpm
Update tests for sspBC adapter
5a90ba4 
Update tests for sspBC adapter:
- change userSync test (due to tcf param appended in v4.6)
- add tests for onBidWon and onTimeout
@wojciech-bialy-wpm
Merge pull request #9 from prebid/master
2183a85 
Update master branch of grupawp/Prebid.js
@wojciech-bialy-wpm
Merge pull request #11 from prebid/master
767334b 
Update remote repo
@wojciech-bialy-wpm
Merge pull request #13 from prebid/master
97d7ccf 
Update grupawp fork
@wojciech-bialy-wpm
Merge pull request #15 from prebid/master
8856c36 
Update remote repository
@wojciech-bialy-wpm
Merge pull request #16 from prebid/master
754df70 
Update remote repository
[sspbc-adapter] 5.3 updates: content-type for notifications
273e7db
[sspbc-adapter] pass CTA to native bid
08c90fb
[sspbc-5.3] keep pbsize for detected adunits
363d342
[maintenance] - remove old test for sspBc bid adaptor
9f9cc49
[sspbc-5.3] increment adaptor ver
22b2afc
[sspbc-adapter] maintenance update to sspBCBidAdapter
62dad10
remove yarn.lock
65a7738
@wojciech-bialy-wpm
Merge pull request #17 from prebid/master
d224072 
Update remote repository
@wojciech-bialy-wpm
Delete package-lock.json
cf9f3e0
remove package-lock.jsonfrom pull request
1721574
update sspbc-5.3 branch
ee21d84
Merge branch 'master' of https://github.com/prebid/Prebid.js into ssp…
170fdcd 
…bc-5.3
[sspbc-adapter] send pageViewId in request
26ca477
[sspbc-adapter] update pageViewId test
2a8278b
@wojciech-bialy-wpm
Merge pull request #19 from prebid/master
14ac217 
Update remote repository
[sspbc-adapter] add viewabiility tracker to native ads
6d5bbd3
[sspbc-adapter] add support for bid.admNative property
75174f6
[sspbc-adapter] ensure that placement id length is always 3 (improves…
7891a9e 
… matching response to request)
[sspbc-adapter] read publisher id and custom ad label, then send them…
ad6a21a 
… to banner creative
[sspbc-adapter] adlabel and pubid are set as empty strings, if not pr…
e422156 
…esent in bid response
[sspbc-adapter] jstracker data fix
9a792f0
[sspbc-adapter] jstracker data fix
9ea4c7c
[sspbc-adapter] send tagid in notifications
4461f6f
wojciech-bialy-wpm and others added 16 commits July 12, 2023 13:44
@wojciech-bialy-wpm
Merge pull request #29 from prebid/master
7bb7efa 
update remote repo
@wojciech-bialy-wpm
cleanup of grupawp/prebid master branch
ac9e623
@wojciech-bialy-wpm
update sspBC adapter to v 5.9
5a206fd
@wojciech-bialy-wpm
update tests for sspBC bid adapter
6d1f2a8
@wojciech-bialy-wpm
Merge pull request #30 from prebid/master
35a190f 
Update remote repo
@wojciech-bialy-wpm
[sspbc-adapter] add support for topicsFPD module
8fd00ff
@wojciech-bialy-wpm
[sspbc-adapter] change topic segment ids to int
e5eba5d
@wojciech-bialy-wpm
Merge pull request #31 from prebid/master
cc82ed7 
Update remote repo
@wojciech-bialy-wpm
merge repo updates
e9c99f8
@wojciech-bialy-wpm
Merge pull request #32 from prebid/master
c501072 
Update remote repo
@wojciech-bialy-wpm
Merge branch 'prebid:master' into master
f093c44
@wojciech-bialy-wpm
Merge pull request #33 from prebid/master
7b8d1a7 
Update grupawp fork
@wojciech-bialy-wpm
Merge pull request #34 from prebid/master
2dc6ce6 
Update fork grupawp
@decemberWP
add pirIdSystem
f88385a
@decemberWP
pirIdSystem
f96e3c6
@decemberWP
piridSystem - preCR
6625b70
@ChrisHuie
Copy link
Collaborator

@decemberWP this looks like it is a month or so behind the current master. Pulling in recent commits should fix your errors here

@decemberWP
Copy link
Contributor Author

@ChrisHuie thanks, done

@ChrisHuie ChrisHuie requested a review from osazos April 8, 2024 09:20
osazos
osazos reviewed Apr 12, 2024
View reviewed changes
modules/pirIdSystem.js Outdated Show resolved Hide resolved
modules/pirIdSystem.js Outdated Show resolved Hide resolved
modules/pirIdSystem.js Show resolved Hide resolved
@osazos osazos self-requested a review April 15, 2024 11:32
osazos
osazos approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@osazos osazos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@osazos osazos merged commit 216c690 into prebid:master Apr 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osazos osazos osazos approved these changes

Assignees

@osazos osazos

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@decemberWP @ChrisHuie @osazos @wojciech-bialy-wpm