Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fledgeForGpt: automatically import paapi for NPM consumers #11269

Merged
merged 1 commit into from Apr 3, 2024

Conversation

dgirardi
Copy link
Collaborator

@dgirardi dgirardi commented Mar 28, 2024

Type of change

  • Bugfix

Description of change

With #10930, fledgeForGpt was made a submodule of paapi. The build automatically includes submodules' parent modules, but this is not the case for NPM consumers.

This also fixes webpack's splitChunk configuration to avoid other, unrelated output duplication - logic that's not pulled in from src/prebid.js, but imported from modules, is duplicated for each module.

@dgirardi dgirardi marked this pull request as draft March 28, 2024 15:12
@dgirardi dgirardi marked this pull request as ready for review March 28, 2024 16:58
@ChrisHuie ChrisHuie requested a review from Fawke April 1, 2024 16:08
@ChrisHuie ChrisHuie requested a review from osazos April 1, 2024 16:08
Copy link
Collaborator

@osazos osazos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Btw, can you explain why this can be removed in Prebid 9?

@dgirardi
Copy link
Collaborator Author

dgirardi commented Apr 2, 2024

why this can be removed in Prebid 9?

We can remove it in 9 because it's a breaking change. We should remove it in 9 because it would bring it in line with how other submodules work (NPM consumers need to explicitly import the parent). Alternatively we could also do the same for all other submodules.

@patmmccann patmmccann merged commit c27f64b into prebid:master Apr 3, 2024
4 checks passed
@dgirardi dgirardi mentioned this pull request Apr 4, 2024
1 task
mefjush pushed a commit to adhese/Prebid.js that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants