fledgeForGpt: automatically import paapi for NPM consumers #11269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osazos
approved these changes
Apr 2, 2024
We can remove it in 9 because it's a breaking change. We should remove it in 9 because it would bring it in line with how other submodules work (NPM consumers need to explicitly import the parent). Alternatively we could also do the same for all other submodules. |
patmmccann
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
With #10930,
fledgeForGptwas made a submodule ofpaapi. The build automatically includes submodules' parent modules, but this is not the case for NPM consumers.This also fixes webpack's
splitChunkconfiguration to avoid other, unrelated output duplication - logic that's not pulled in fromsrc/prebid.js, but imported from modules, is duplicated for each module.