core: allow bid adapters to return null fledgeAuctionConfigs #11271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgirardi
force-pushed
the
allow-object-adapter-response
branch
from
807dfa0
to
b0ce604
Compare
dgirardi
force-pushed
the
allow-object-adapter-response
branch
from
b0ce604
to
bb4bdbb
Compare
robertrmartinez
approved these changes
Apr 2, 2024
|
Excellent suggestion @robertrmartinez. As a punishment for it, you'll need to review again. |
dgirardi
force-pushed
the
allow-object-adapter-response
branch
from
e6d2edd
to
e6fa848
Compare
dgirardi
force-pushed
the
allow-object-adapter-response
branch
from
e6fa848
to
a514701
Compare
robertrmartinez
approved these changes
Apr 2, 2024
| throw new Error(`Adapter response should use ${PAAPI_RESPONSE_PROPS[0]} over ${PAAPI_RESPONSE_PROPS[1]}, not both`); | ||
| } | ||
| return paapi ?? fledge; | ||
| } |
| bids: bids, | ||
| [paapiProp]: [paapiConfig] | ||
| }); | ||
| bidder.callBids(bidRequest, addBidResponseStub, doneStub, ajaxStub, onTimelyResponseStub, wrappedCallback); |
There was a problem hiding this comment.
maybe a test for prefers 'paapiAuctionConfigs' over 'fledgeAuctionConfigs' if both defined?
Prob not a real life scenario though so maybe not!
mefjush
pushed a commit
to adhese/Prebid.js
that referenced
this pull request
Apr 8, 2024
…11271) * core: allow bid adapters to return null fledgeAuctionConfigs * Accept paapiAuctionConfigs from adapters * add test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Allow adapters to return an object with null/undefined paapi configs (e.g.
{bids: [...]}), to avoid boilerplate that unwraps return values from ortbConverter.