Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EXADS Bid Adapter: initial release #11284

Merged
merged 48 commits into from May 2, 2024
Merged

EXADS Bid Adapter: initial release #11284

merged 48 commits into from May 2, 2024

Conversation

giuseppe-exads
Copy link
Contributor

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

doc - prebid/prebid.github.io#5237

@giuseppe-exads
First commit
295e037
@giuseppe-exads
fix: readme.md
3dcb786
@giuseppe-exads
fix: changed exads urls
30eb51e
@giuseppe-exads
fix: Tools and suggestions related to the doc
1e83db3
@giuseppe-exads
fix: from code review
38caa60
@giuseppe-exads
fix: from code review
bad299c
@giuseppe-exads
fix: from code review
0a4caf6
@giuseppe-exads
fix: error from code review - native example
9439670
@giuseppe-exads
fox: from code review
4965cfc
@giuseppe-exads
fix: from code review
091f340
@giuseppe-exads
fix: from code review
72163cf
@giuseppe-exads
fix: native img set as mandatory
e0740ba
@giuseppe-exads
fix: from code review
ec22581
@giuseppe-exads
fix: from code review
08b94c8
@giuseppe-exads
fix: from code review
fc03f90
@giuseppe-exads
Merge branch 'master' into EX-16373
f4431a8
@giuseppe-exads
fix: from code review
9b8ac1f
@giuseppe-exads
fix: from code review
d153e9a
@giuseppe-exads
fix: from code review
47bc992
@giuseppe-exads
fix: bidfloor and bidfloorcur set as optional
20edd7b
@giuseppe-exads
fix: dsa
a047b32
@giuseppe-exads
fix: mananing multiple responses
17d705a
@giuseppe-exads
fix: unit test after code review
c2df4a1
@giuseppe-exads
fix: fixing native snippet code
f264a20
@giuseppe-exads
fix: from code review
a89f377
@giuseppe-exads
fix: video events after code review
06b8349
@giuseppe-exads
fix: video module into documentation
e3e8056
@giuseppe-exads
fix: impression tracker for native
2cee2f3
@giuseppe-exads
fix: afeter code review
cbf78f7
@giuseppe-exads
fix: unit tests
0c58be6
@muuki88 muuki88 mentioned this pull request Apr 4, 2024
Merged
7 tasks
muuki88
muuki88 reviewed Apr 4, 2024
View reviewed changes
modules/exadsBidAdapter.js
return envParams;
}

export const imps = new Map();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why exporting a global map?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm exporting it in order to make it testable. I'm using it into unit tests. An alternative could be making it as a property of the "spec" object.

muuki88
muuki88 reviewed Apr 4, 2024
View reviewed changes
modules/exadsBidAdapter.js

export const spec = {
aliases: ['exads'], // short code
supportedMediaTypes: [BANNER, NATIVE, VIDEO],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing your GVL_ID here ( 1084 )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are good. Just put the GVL_ID.

@ChrisHuie ChrisHuie requested a review from Rothalack April 8, 2024 09:21
@Rothalack
Copy link
Collaborator

Hey @giuseppe-exads , I'm trying to test and I have been unable to get any valid bid to go through. It's always either invalid or errors out. Do you have a set of params that would work for a test?

@giuseppe-exads
Copy link
Contributor Author

Hey @giuseppe-exads , I'm trying to test and I have been unable to get any valid bid to go through. It's always either invalid or errors out. Do you have a set of params that would work for a test?

Hey @Rothalack,

I've configured one test for you on our adservers. It is related to a banner 300x250. You can interact with it using our prebidJS adapter, using the next model and param.

Attention to some parameters! For some params you need to specify your custom values. Read the comments near to some params for more information.

I've tested it on my side and it works.

Let me know if you need other information and /or other tests. Thanks so much.

{
    "code": "postbid_iframe",  // specify your value based on your web site
    "mediaTypes": {
        "banner": {
            "sizes": [
                [
                    300,
                    250
                ]
            ]
        }
    },
    "bids": [
        {
            "bidder": "exadsadserver",
            "params": {
                "zoneId": 390,
                "fid": "885643a525fc065497d80df32141dfcce4b9447a",
                "partner": "ortb_2_4",
                "siteId": "12345",
                "siteName": "www.google.com",
                "userIp": "37.228.226.18", // your user ip
                "userId": "2177189013422152",
                "country": "IRL", // your country code
                "impressionId": "8694154782644030", // you can leave it or specify one custom id
                "keywords": "Category 1",
                "bidfloor": 1.1e-7,
                "bidfloorcur": "EUR",
                "bcat": [
                    "IAB25",
                    "IAB7-39",
                    "IAB8-18",
                    "IAB8-5",
                    "IAB9-9"
                ],
                "badv": [
                    "first.com",
                    "second.com"
                ],
                "mimes": [
                    "image/jpg"
                ],
                "dsa": {
                    "dsarequired": 3,
                    "pubrender": 0,
                    "datatopub": 2
                },
                "imageOutput": "html",
                "endpoint": "https://rtb.adnflow.com/rtb.php"
            }
        }
    ]
}

Rothalack
Rothalack approved these changes May 2, 2024
View reviewed changes
Copy link
Collaborator

@Rothalack Rothalack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, I thought I had already approved and merged this. This is working in testing for me, thanks for the testing set up!

@Rothalack Rothalack merged commit 8c72bc2 into prebid:master May 2, 2024
4 checks passed
@giuseppe-exads
Copy link
Contributor Author

Thanks @Rothalack!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rothalack Rothalack Rothalack approved these changes

@muuki88 muuki88 Awaiting requested review from muuki88

Assignees

@Rothalack Rothalack

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@giuseppe-exads @Rothalack @muuki88 @ChrisHuie @tfoliveira