Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid requests generated by minuteMedia and rise bid adapters #11289

Open
Sir-Will opened this issue Apr 4, 2024 · 1 comment
Open

Invalid requests generated by minuteMedia and rise bid adapters #11289

Sir-Will opened this issue Apr 4, 2024 · 1 comment

Comments

@Sir-Will
Copy link

Sir-Will commented Apr 4, 2024 •
edited

Type of issue

Bug

Description

The util function getBidIdParameter can cause the returned value and type to change. E.g. when the value is 0 it ends up being an empty string.

I'm not sure if the bidders are not handling it correctly or if this is a not intended side effect.

There are bidder endpoints, like the ones below, which expect an integer, but end up receiving a string and result in a 400 request.

Other information
@dgirardi
Copy link
Collaborator

dgirardi commented Apr 4, 2024 •
edited

getBidIdParameter is from ancient times, when requests were GET and everything was a string. Over time it was copied all over the place and I'd be surprised if that fallback still makes sense for more than a handful of adapters, but it's so baked-in that the bug is now a feature. There's not much we can do to fix it besides alerting adapters about specific issues.

FYI @YakirLavi

@dgirardi dgirardi changed the title getBidIdParameter util function causing 0 to change to empty string Invalid requests generated by minuteMedia and rise bid adapters Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Prebid.js Tactical Issues table
Status: Tracking
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Sir-Will @dgirardi