Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kargo Bid Adapter : refactors code for userIds and updates userId tests #11298

Merged
merged 1 commit into from Apr 9, 2024

Conversation

nickllerandi
Copy link
Contributor

Type of change

  • Refactoring (no functional changes, no api changes)

Description of change

This PR refactors the getUserIds function to improve readability and maintainability.

  • Minor enhancements around code readability and maintainability.
  • Consolidated TDID handling conditions.
  • Removed unnecessary try...catch block
  • Unit tests updated to ensure support for outlier User ID sub-modules

Co-authored-by: “Nick <“nick.llerandi”@kargo.com>
@nickllerandi
Copy link
Contributor Author

A little confused by the failing CircleCI test. I don't think that has to do with these changes.

@ChrisHuie ChrisHuie self-assigned this Apr 9, 2024
@ChrisHuie ChrisHuie changed the title Kargo Bid Adapter: Refactors code for userIds; updates userId tests Kargo Bid Adapter : refactors code for userIds and updates userId tests Apr 9, 2024
@ChrisHuie ChrisHuie merged commit db0b1bd into prebid:master Apr 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants