Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pubx.ai RTD Provider - Initial Release #11300

Merged
merged 28 commits into from May 1, 2024
Merged

Pubx.ai RTD Provider - Initial Release #11300

merged 28 commits into from May 1, 2024

Conversation

pruthvimuga
Copy link
Contributor

@pruthvimuga pruthvimuga commented Apr 5, 2024 •
edited

Type of change

  • feature

Description of change

  • Fetch RTD data to set dynamic floors from pubx.ai floors endpoint. This RTD module provides greater control over the dynamic floors returned from Pubx.ai and works well with Pubx.ai's flooring solutions.

Other information

pnhegde and others added 27 commits February 2, 2024 16:14
@pnhegde
Add pubx RTD module
fe4b493
@pnhegde
Add pubx RTD module documentation
2ceafa4
@pnhegde
Add basic tests for pubx RTD module
99da428
@pnhegde
Fix the failing tests
72db7e1
@pnhegde
Added logic to fetch floors and set to auction
9f9c78f
@pnhegde
Updated setDataToConfig to attach floors data to bidder requests object
d5ad5e2
@pruthvimuga
pubx rtd module:
c2bc4d9 
* fetch floor rules
* timeout defaults
* floors config customizations
* pubx on/off from floors response
@pruthvimuga
move fetch floors to init and also wait for it before auction
5473a62
@pruthvimuga
TESTS: update
abf021b
@pruthvimuga
replace createFloorsDataForAuction to avoid circular dep - WIP
361d83d
@pruthvimuga
reset default floors when no floor response is received
f37e645
@pruthvimuga
TESTS: add test
5baa9fe
@pruthvimuga
tag integration - fetch floors api events
451f552
@pruthvimuga
* Remove coonsole.log
f32ebdd 
* move __pubxFloorRulesPromise__ to window
* Remove unused var error
@pruthvimuga
TESTS: add getBidRequestData, refactor stubs
fd15c9f
@pruthvimuga
TESTS: setFloorsApiStatus
d39782b
@pruthvimuga
TESTS: add fetchFloorRules
56208b0
@pruthvimuga
Merge branch 'master' into pubx-rtd-module
51581f7
@pruthvimuga
remove useRtd
6bb5196
@pruthvimuga
make endpoint potional and take pubxId form provider config
4e8332c
@pruthvimuga
TESTS: use xhr to fakeServer instead of sinon
3bdfbc6
@pruthvimuga
make default data optional
5cecc4c
@pruthvimuga
update README
f4798aa
@pruthvimuga
TEST: update tests
04041f7
@pruthvimuga
add integration example
87bde8a
@pruthvimuga
remove floorProvider from default config
2ed5aa9
@pruthvimuga
fix linting
b5e3821
@pruthvimuga pruthvimuga mentioned this pull request Apr 5, 2024
Closed
9 tasks
@pruthvimuga pruthvimuga mentioned this pull request Apr 9, 2024
Merged
2 tasks
@pruthvimuga pruthvimuga changed the title Pubx.ai Rtd Provider [Pubx.ai](https://pubx.ai/) RTD Provider - Initial Release Apr 9, 2024
@pruthvimuga pruthvimuga changed the title [Pubx.ai](https://pubx.ai/) RTD Provider - Initial Release Pubx.ai RTD Provider - Initial Release Apr 9, 2024
@pruthvimuga pruthvimuga marked this pull request as ready for review April 9, 2024 11:45
@ChrisHuie ChrisHuie self-requested a review April 9, 2024 14:28
@ChrisHuie ChrisHuie self-assigned this Apr 9, 2024
@ChrisHuie ChrisHuie requested review from Fawke and removed request for ChrisHuie April 15, 2024 14:08
@ChrisHuie ChrisHuie assigned Fawke and unassigned ChrisHuie Apr 15, 2024
Fawke
Fawke approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@Fawke Fawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fawke Fawke merged commit 51c63b6 into prebid:master May 1, 2024
4 checks passed
@pnhegde pnhegde deleted the pubx-rtd-module branch May 2, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fawke Fawke Fawke approved these changes

Assignees

@Fawke Fawke

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pruthvimuga @Fawke @ChrisHuie @pnhegde