Performax Bid Adapter: New bidder adapter #11325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lukashakl could you link your prebid website docs PR? |
8 tasks
|
|
@lukashakl Sorry for the delay in the review, looks like your PR doesn't have unit tests committed. Could you add those? |
ncolletti
reviewed
Apr 24, 2024
Thanks for response. I add unit test today. It´s ok now? |
|
@ncolletti do you have any idea why this CI failed? I haven´t found anything related to my request in logs and I´m not able re-run this tests. |
|
@lukashakl there are some flaky integration tests that can fail, unrelated to your changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
New bidder adapter