Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performax Bid Adapter: New bidder adapter #11325

Merged
merged 13 commits into from May 7, 2024

Conversation

lukashakl
Copy link
Contributor

@lukashakl lukashakl commented Apr 11, 2024

Type of change

  • New bidder adapter

Description of change

New bidder adapter

@ncolletti
Copy link
Contributor

@lukashakl could you link your prebid website docs PR?

@lukashakl
Copy link
Contributor Author

@lukashakl could you link your prebid website docs PR?
Sorry, there it is prebid/prebid.github.io#5259

@ncolletti
Copy link
Contributor

@lukashakl Sorry for the delay in the review, looks like your PR doesn't have unit tests committed. Could you add those?

@lukashakl
Copy link
Contributor Author

@lukashakl Sorry for the delay in the review, looks like your PR doesn't have unit tests committed. Could you add those?

Thanks for response. I add unit test today. It´s ok now?

@lukashakl
Copy link
Contributor Author

@ncolletti do you have any idea why this CI failed? I haven´t found anything related to my request in logs and I´m not able re-run this tests.
image

@ncolletti
Copy link
Contributor

@lukashakl there are some flaky integration tests that can fail, unrelated to your changes

Copy link
Contributor

@ncolletti ncolletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ncolletti ncolletti merged commit eb5ae98 into prebid:master May 7, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants