Alkimi Bid Adapter : add handling for user-sync URL and pass custom object with bid request #11326
Conversation
merge master
merge master
merge master
Sending no decode whole url options to true, to avoid errors while de…
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
|
Hi I am not sure why the e2etest is failing, Could you please check this and help on this failure? if it's possible could you please rerun the e2etest from your side? thanks. |
ChrisHuie
changed the title
Sometimes the e2e testing is flaky. Don't worry about it. |
|
Hello We are waiting for his change to be merged, Could you please check and approve it? Thanks. |
| @@ -141,6 +152,24 @@ export const spec = { | |||
| return true; | |||
| } | |||
| return false; | |||
| }, | |||
|
|
|||
| getUserSyncs: function(syncOptions, serverResponses, gdprConsent) { | |||
There was a problem hiding this comment.
you are not passing along any of gdprConsent, uspConsent, gppConsent to your sync urls.
Just want to confirm this is intended.
There was a problem hiding this comment.
we resolve gdpr info on server
modules/alkimiBidAdapter.js
Outdated
| if (!serverBody || typeof serverBody !== 'object') return []; | ||
|
|
||
| const { iframeList } = serverBody; | ||
| if (!iframeList || typeof iframeList !== 'object') return []; |
There was a problem hiding this comment.
If iframeList is an object but not an array you may get an error below. Maybe change this to
if (!Array.isArray(iframeList)) return [];There was a problem hiding this comment.
@robertrmartinez Could you please check the latest changes and approve? Thanks.
|
Hello @robertrmartinez / @ChrisHuie Could you please check this change and approve it? We are completely blocked deliver this change. Thanks. |
Type of change
Feature
[No] Does this change affect user-facing APIs or examples documented on http://prebid.org?
Description of change
Other information