Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PubMatic Bid Adapter : remove transformBidParams function #11328

Merged
merged 2 commits into from Apr 15, 2024

Conversation

kapil-tuptewar
Copy link
Contributor

@kapil-tuptewar kapil-tuptewar commented Apr 12, 2024

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

This function was supposed to convert publisherId & adSlot to string but required data type for these fields are already in string.

@kapil-tuptewar kapil-tuptewar changed the title PubMatic Bid Adapter : remove transformBidParams function WIP PubMatic Bid Adapter : remove transformBidParams function Apr 12, 2024
@kapil-tuptewar kapil-tuptewar marked this pull request as draft April 12, 2024 09:12
@kapil-tuptewar kapil-tuptewar marked this pull request as ready for review April 15, 2024 08:25
@kapil-tuptewar kapil-tuptewar changed the title WIP PubMatic Bid Adapter : remove transformBidParams function PubMatic Bid Adapter : remove transformBidParams function Apr 15, 2024
@ChrisHuie ChrisHuie self-assigned this Apr 15, 2024
@ChrisHuie ChrisHuie merged commit 32eebd0 into prebid:master Apr 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants