Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JW Player Bid Adapter : initial release #11344

Merged
merged 48 commits into from Apr 25, 2024
Merged

JW Player Bid Adapter : initial release #11344

merged 48 commits into from Apr 25, 2024

Conversation

karimMourra
Copy link
Collaborator

Type of change

  • New bidder adapter

Description of change

Introduces the new JW Player Bid Adapter

Other information

Docs PR: prebid/prebid.github.io#5256

jorgeluisrocha and others added 30 commits April 12, 2024 19:07
@jorgeluisrocha @karimMourra
jwplayerBidAdapter module created
2dd30b1
@jorgeluisrocha @karimMourra
created initial skeleton of jwplayerBidAdapter
18df888
@jorgeluisrocha @karimMourra
cleaned up initial skeleton for jwplayerBidAdapter
6a48b9c
@jorgeluisrocha @karimMourra
added description to jwplayerBidAdapter.md
4978531
@jorgeluisrocha @karimMourra
created jwplayerBidAdapter unit test suite
8f53929
@jorgeluisrocha @karimMourra
implemented isBidRequestValid with unit tests
9d410f8
@jorgeluisrocha @karimMourra
initial creation of the buildRequests function
3480a19
@jorgeluisrocha @karimMourra
incorporated feedback from pr and refactored.
30909e6
@jorgeluisrocha @karimMourra
added video object, impExt object, and site content object to jwplaye…
e44c89b 
…rBidAdapter
@jorgeluisrocha @karimMourra
added feedback from pr
1ffdf1b
@jorgeluisrocha @karimMourra
fixed parameters for methods in jwplayerBidAdapter
1806a93
@jorgeluisrocha @karimMourra
added feedback from pr and unit tests
2ccf740
@jorgeluisrocha @karimMourra
removed superfluous array
147170a
@jorgeluisrocha @karimMourra
fixed nits
2bc3a21
@jorgeluisrocha @karimMourra
added feedback to jw adapter and tests for buildRequests
6064e40
@jorgeluisrocha @karimMourra
added feedback
b3092c1
@jorgeluisrocha @karimMourra
one last feedback for request site
13c3deb
@jorgeluisrocha @karimMourra
added site object unit test
adef057
@jorgeluisrocha @karimMourra
fixed buildRequestSite object
c504d05
@jorgeluisrocha @karimMourra
added unit tests for site object
d746cf4
@jorgeluisrocha @karimMourra
fixed unit tests for buildRequestSite
8e54e50
@jorgeluisrocha @karimMourra
skeleton of interpretResponse
6b0ef47
@jorgeluisrocha @karimMourra
initial attempt at interpretResponse
61a4705
@jorgeluisrocha @karimMourra
started unit test
9cd64d9
@jorgeluisrocha @karimMourra
finished interpretResponse with unit test
a361926
@karimMourra
populates schain as well as other params
93a1fcf
@karimMourra
reads schain from bidrequest
ac73525
@karimMourra
updates unit tests
3a36eaf
@karimMourra
improves tests
9a49f6a
@karimMourra
tests tmax
7cbc23c
@karimMourra karimMourra mentioned this pull request Apr 15, 2024
Merged
3 tasks
@ChrisHuie ChrisHuie changed the title Module: JW Player Bid Adapter JW Player Bid Adapter : initial release Apr 16, 2024
@ChrisHuie ChrisHuie self-requested a review April 24, 2024 19:55
@ChrisHuie ChrisHuie assigned ChrisHuie and unassigned mmoschovas Apr 25, 2024
@ChrisHuie ChrisHuie removed the request for review from mmoschovas April 25, 2024 12:47
@ChrisHuie ChrisHuie merged commit fadc303 into prebid:master Apr 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisHuie ChrisHuie ChrisHuie approved these changes

Assignees

@ChrisHuie ChrisHuie

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@karimMourra @ChrisHuie @mmoschovas @jorgeluisrocha