Dailymotion Bid Adapter: accept ortb2 field #11366
Merged
+354
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dailymotion Bid Adaptor: initial release
The same way as we can have an array of IAB categories level 1 in the ORTB request, this PR introduces an array for the IAB categories level 2. To be forward compatible with level [2.2](https://github.com/InteractiveAdvertisingBureau/Taxonomies/blob/main/Content%20Taxonomies/Content%20Taxonomy%202.2.tsv) and [3.0](https://github.com/InteractiveAdvertisingBureau/Taxonomies/blob/main/Content%20Taxonomies/Content%20Taxonomy%203.0.tsv) specifications, the category IDs should be sent as strings.
feat(LEO-528): Allow multiple IAB categories level 2 in video metadata
Dailymotion bid adapter: Clarify the video metadata to provide in each player context
Co-authored-by: Rumesh <rumesh@users.noreply.github.com>
…to_bidparam Dailymotion bid adapter: Move API key to bid params (fix tests)
Dailymotion Bid Adaptor: add iabcat1 and fallback to ortb2 for iabcat2
…ocument mapping of ortb2 fpd to video metadata
Note: I changed the case of `startdelay` to be consistent with the other parameters, but it won't have any impact on current deployments as this parameter is not used onsite.
…deo_fields Dailymotion Bid Adaptor: Add standard ORTB video parameters
# Conflicts: # modules/dailymotionBidAdapter.js # modules/dailymotionBidAdapter.md # test/spec/modules/dailymotionBidAdapter_spec.js
Merge upstream
|
Sorry for the long list of commits coming from the upstream merge in our fork. We'll rebase it as soon as this one is merged. cc. @patmmccann and @karimMourra, thanks again for your time and comments, we are open to any new suggestion :) |
patmmccann
changed the title
karimMourra
requested changes
Apr 19, 2024
modules/dailymotionBidAdapter.js
Outdated
| @@ -38,17 +45,22 @@ function getVideoMetadata(bidRequest, bidderRequest) { | |||
| const videoMetadata = { | |||
| description: videoParams.description || '', | |||
| duration: videoParams.duration || 0, | |||
There was a problem hiding this comment.
Suggested change
| duration: videoParams.duration || 0, | |
| duration: videoParams.duration || contentObj.len || 0, |
Per spec: len - integer - Length of content in seconds; appropriate for video or audio
|
Thanks @karimMourra for all the suggestions. I think @kvnsw adressed all of them, could you confirm please ? |
patmmccann
approved these changes
May 7, 2024
|
LGTM @karimMourra if you have additional feedback let's handle in subsequent pr's |
|
Apologies, I lost track of this PR. The changes look great thank you for addressing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This addresses the comments that we received after #10970 was merged.
The main changes are: