Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sirdata RTD Module : fix empty bidders param array bug & various optimizations #11367

Merged
merged 2 commits into from Apr 22, 2024

Conversation

nouchy
Copy link
Contributor

@nouchy nouchy commented Apr 19, 2024

Type of change

  • Bugfix
  • Refactoring (no functional changes, no api changes)

Description of change

There was a bug relating to the module configuration parameters, when the publishers adds a filter for bidders and this filter is empty (empty array). We added a control on the length of the array which must be greater than 0, and optimized the code by removing parameters that had become obsolete.

Copy link
Collaborator

@osazos osazos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@osazos osazos merged commit 3d23dfe into prebid:master Apr 22, 2024
4 checks passed
mefjush pushed a commit to adhese/Prebid.js that referenced this pull request Apr 25, 2024
…mizations (prebid#11367)

* fix empty params array bug & various optimizations

* Update sirdataRtdProvider.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants