New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New PAAPI module: topLevelPaapi #11379
Open
dgirardi
wants to merge
26
commits into
prebid:master
Choose a base branch
from
dgirardi:paapi-tls-improve
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
requestedSize
handling as described in PAAPI module: fill out auctionSignals.prebid.ortb2Imp.banner better #11189 (comment)topLevelPaapi
, intended for pubs running top level auctions. Example configuration:auctionConfig
is reflected bygetPAAPIConfig()
.pbjs.getPAAPIBids()
, which accepts the same filters asgetPAAPIConfig
, and returns a promise to a map from ad unit code to paapi auction result (obtained by callingrunAdAuction
).The auction result is an object with the format
{adId, adUnitCode, auctionId, width, height, urn, frameConfig}
(whereurn
andframeConfig
are mutually exclusive)adId
generated bygetPAAPIBids()
can be rendered withpbjs.renderAd
like "normal" adIdsautorun
, if true (the default), startsrunAdAuction
ASAP (currently, that's when the Prebid auction ends)overrideWinner
, if true (default is false), makes it so that PAAPI bids are rendered instead of the contextual winner.For example, callingrenderAd()
or rendering PUC / other creatives in the normal way would check if there's a a PAAPI bid for the ad slot, and if so render that instead.paapiRunAuction
,paapiBid
,paapiNoBid
, andpaapiError
Other information
Closes #11189
Closes: #10690