Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Called replaceAuctionMacro in viantOrtbBidAdapter to replace Auction_Price #11394

Merged

Conversation

skapoorViant
Copy link
Contributor

@skapoorViant skapoorViant commented Apr 24, 2024

Called replaceAuctionMacro in viantOrtbBidAdapter to replace Auction_Price

Type of change

  • Bugfix

Description of change

Auction price macro was not getting expanded for bids won with Viant Adapter. Explicitly called replaceAuctionPrice method from utils.js to get the correct value.

@skapoorViant
Copy link
Contributor Author

skapoorViant commented Apr 25, 2024

@dgirardi can you please review whenever you get a chance? We have a blocker on our side related to the Auction_Price macro issue https://github.com/prebid/Prebid.js/issues/11387. We need to get this PR merged soon.

@skapoorViant
Copy link
Contributor Author

@patmmccann can you please merge this pull request, we have a blocker on our side related to AUCTION_PRICE macro, and we need your help to merge this PR soon.

@dgirardi dgirardi merged commit 0fd106d into prebid:master Apr 25, 2024
4 checks passed
@@ -51,8 +51,10 @@ export const spec = {
onBidWon: function (bid) {
if (bid.burl) {
utils.triggerPixel(bid.burl);
utils.replaceAuctionPrice(bid.burl, bid.price);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skapoorViant, I aplogize for thinking about this only after merging.

I don't think this does what you want. it should probably be

utils.triggerPixel(utils.replaceAuctionPrice(bid.burl, bid.originalCpm || bid.cpm))

you can do the same for nurl, but by the time this runs it will be a duplicate call.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no worries, but in the bidresponse we are sending bid.price and not bid.originalCpm or bid.cpm, so would it be good if I just write it as
utils.triggerPixel(utils.replaceAuctionPrice(bid.burl, bid.price||bid.originalCpm || bid.cpm))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants