ViantOrtb Bid Adapter : called replaceAuctionMacro to replace Auction_Price #11398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dgirardi created this new pull request as per your feedback. Thank you. |
dgirardi
approved these changes
Apr 25, 2024
|
@dgirardi i have cleaned it up. Please merge it. |
ChrisHuie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Called replaceAuctionMacro in viantOrtbBidAdapter to replace Auction_Price
Type of change
Description of change
Auction price macro was not getting expanded for bids won with Viant Adapter. Explicitly called replaceAuctionPrice method from utils.js to get the correct value.