Various Adapters: Delete s2s transform bid params for adapters with no server equivalent #11402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmmccann
changed the title
|
Prep for prebid 9 but since none of these s2s adapters, this isn't breaking |
osazos
reviewed
May 2, 2024
Comment on lines
-115
to
-119
| transformBidParams: function (params, isOpenRtb) { | ||
| if (!baseAdapter.transformBidParams) { return params; } | ||
| return baseAdapter.transformBidParams(params, isOpenRtb); | ||
| }, | ||
|
|
There was a problem hiding this comment.
Just to confirm, this adapter extends appnexusBidAdapter which uses this function. Was this taken into consideration?
There was a problem hiding this comment.
they were confirmed as not having a server side adapter by @bretg
ChrisHuie
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #6361