Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relevant Digital Bid Adapter : remove 'transformBidParams' #11412

Conversation

samuel-palmer-relevant-digital
Copy link
Contributor

Type of change

  • Other

Description of change

This PR removes transformBidParams from our bid adapter in preparation for Prebid 9. This can be done as it only affects a very unusual use-case which there is an easy workaround for - provide the required settings inside params instead of using pbjs.setConfig() as described here, when using S2S.

@ChrisHuie ChrisHuie changed the title Relevant Digital bid adapter: remove 'transformBidParams' Relevant Digital Bid Adapter : remove 'transformBidParams' Apr 29, 2024
@ChrisHuie ChrisHuie self-assigned this Apr 29, 2024
@ChrisHuie ChrisHuie merged commit 7b77515 into prebid:master Apr 29, 2024
4 checks passed
ChrisHuie pushed a commit that referenced this pull request May 6, 2024
* sovrn analytics adapter: remove analytics adapter

* delete md

* Appnexus Bid Adapter: add support for ast_override_div debug feature (#11390)

* ConsentManagementGpp module: throw error on some invalid sections (#11385)

* Update consentManagementGpp.js

* Update consentManagementGpp.js

* Update consentManagementGpp.js

* Update consentManagementGpp.js

* Update modules/consentManagementGpp.js

Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>

---------

Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>

* appnexusBidAdapter - video plcmt logic fix (#11403)

* Remove 'transformBidParams' from relevantdigitalBidAdapter (#11412)

* resolve conflicts/merge

---------

Co-authored-by: Chris Prokopiak <cprokopiak@sovrn.com>
Co-authored-by: Dmitry Sinev <astartsky@pm.me>
Co-authored-by: Patrick McCann <patmmccann@gmail.com>
Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>
Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com>
Co-authored-by: samuel-palmer-relevant-digital <77437973+samuel-palmer-relevant-digital@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants