Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubicon Bid Adapter: Provide backwards compatibility for transparency object #11426

Merged
merged 5 commits into from May 8, 2024

Conversation

harrykingriches
Copy link
Contributor

Type of change

  • [ x] Bugfix

Description of change

When the property transparency.params gets passed in the ortb2 object, the Rubicon adapter throws an error.

This change will provide backwards compatibility for the params property by adding it to the dsaparams property.

If params or dsaparams does not exist, the value will be turned into an empty string. The same is done for the domain property. This ensures that the Bid Adapter will not error if these properties do not exist.

When the property `transparency.params` gets passed in the `ortb2` object, the Rubicon adapter throws an error. 

This change will provide backwards compatibility for the `params` property by adding it to the `dsaparams` property.

If `params` or `dsaparams` does not exist, the value will be turned into an empty string. The same is done for the `domain` property. This ensures that the Bid Adapter will not error if these properties do not exist.
@robertrmartinez
Copy link
Collaborator

Thanks @Strife9224

Could you add a unit test or two covering this use case

@robertrmartinez robertrmartinez self-requested a review April 30, 2024 16:43
Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one fix + add unit tests

modules/rubiconBidAdapter.js Outdated Show resolved Hide resolved
@ChrisHuie ChrisHuie self-requested a review April 30, 2024 17:11
@ChrisHuie ChrisHuie self-assigned this Apr 30, 2024
Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertrmartinez robertrmartinez merged commit 85fd44e into prebid:master May 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants