New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EXADS Bid Adapter : update bidder code before adapter is published #11464
Conversation
EX-16373 - PrebidJS Adapter
Changed bidder code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't let me select the block of code. Line 322 is where I am talking about -> This is all in first party data and doesn't need to be accessed this way
@giuseppe-exads can you please fix conflicts. Want to make sure and get this in before we release this afternoon or tomorrow's version of prebid so the adapter code is never changed for anyone. |
Hi @ChrisHuie, thanks for your consideration. I'll share it with my team and we'll plan the changes just possible. |
Conflict just fixed. |
Sorry @ChrisHuie, only one question. After your merging I've tried to download the prebidJS.
Probably because we have to wait the next release? If it is so when is it planned? |
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Changed bidder code from exadsadserver to exads to comply with the filename convention: ${bidderCode}BidAdapter.js.
Fixed getEnvParams as specified in #11456.
Other information