Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXADS Bid Adapter : update bidder code before adapter is published #11464

Merged
merged 53 commits into from May 8, 2024

Conversation

giuseppe-exads
Copy link
Contributor

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Changed bidder code from exadsadserver to exads to comply with the filename convention: ${bidderCode}BidAdapter.js.
Fixed getEnvParams as specified in #11456.

Other information

Copy link
Collaborator

@ChrisHuie ChrisHuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't let me select the block of code. Line 322 is where I am talking about -> This is all in first party data and doesn't need to be accessed this way

@ChrisHuie ChrisHuie self-requested a review May 8, 2024 14:22
@ChrisHuie ChrisHuie self-assigned this May 8, 2024
@ChrisHuie ChrisHuie changed the title EXADS adapter - Changed bidder code EXADS Bid Adapter : update bidder code before adapter is published May 8, 2024
@ChrisHuie
Copy link
Collaborator

@giuseppe-exads can you please fix conflicts. Want to make sure and get this in before we release this afternoon or tomorrow's version of prebid so the adapter code is never changed for anyone.

@giuseppe-exads
Copy link
Contributor Author

Wouldn't let me select the block of code. Line 322 is where I am talking about -> This is all in first party data and doesn't need to be accessed this way

Hi @ChrisHuie, thanks for your consideration. I'll share it with my team and we'll plan the changes just possible.

@giuseppe-exads
Copy link
Contributor Author

@giuseppe-exads can you please fix conflicts. Want to make sure and get this in before we release this afternoon or tomorrow's version of prebid so the adapter code is never changed for anyone.

Conflict just fixed.

@ChrisHuie ChrisHuie merged commit 8c5c9d5 into prebid:master May 8, 2024
4 checks passed
@giuseppe-exads
Copy link
Contributor Author

giuseppe-exads commented May 8, 2024

Sorry @ChrisHuie, only one question. After your merging I've tried to download the prebidJS.
To do that I've navigated to https://docs.prebid.org/download.html and selected our EXADS adapter, but I get a short file of a few bytes containing:

{"error":"Prebid file not built properly","requestId":"ad6b1e82-7a59-4a0b-97ed-031c4bdb1d20"}

Probably because we have to wait the next release? If it is so when is it planned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants