Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unite rendering examples #9435

Closed
patmmccann opened this issue Jan 18, 2023 · 2 comments · Fixed by #11405
Closed

Unite rendering examples #9435

patmmccann opened this issue Jan 18, 2023 · 2 comments · Fixed by #11405
Labels
9.0 API Change maintenance

Comments

@patmmccann
Copy link
Collaborator

Type of issue

Feature request

Description

https://github.com/prebid/Prebid.js/blob/master/integrationExamples/gpt/x-domain/creative.html and https://github.com/prebid/Prebid.js/blob/master/integrationExamples/gpt/creative_rendering.html
are prebid creatives respectively. We should publish one creative that detects it is in a safeframe and does the former logic if not, the latter if so.
@dgirardi
Copy link
Collaborator

Related: #9647

The cross-domain should work in both cases, and especially after that PR, there should be very little difference - and no reason to have the pbjs.renderAd example.

@patmmccann
Copy link
Collaborator Author

delete https://github.com/prebid/Prebid.js/blob/master/integrationExamples/gpt/creative_rendering.html will solve this

@patmmccann patmmccann mentioned this issue Apr 26, 2024
Merged
@patmmccann patmmccann linked a pull request Apr 26, 2024 that will close this issue
PB9: Delete integrationExamples/gpt/creative_rendering.html #11405
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
9.0 API Change maintenance
Projects
Prebid.js Tactical Issues table
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PB9: Delete integrationExamples/gpt/creative_rendering.html prebid/Prebid.js
2 participants
@patmmccann @dgirardi